The header element of the page template of the Seven theme is marked up with a redundant [role="navigation"] ARIA landmark. The role of the header isn't navigation. It's a container. It can contain breadcrumbs, which are correctly marked up as [role="navigation"].

Screenshot of the Chrome dev tools showing the role=navigation attribute on the header element of the seven themes page template

CommentFileSizeAuthor
#1 redundant-role-navigation-2047061-1.patch1.03 KBjessebeach
Screenshot of the Chrome dev tools showing the role=navigation attribute on the header element of the seven themes page template34.4 KBjessebeach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Active » Needs review
Issue tags: +Accessibility, +TwinCities
FileSize
redundant-role-navigation-2047061-1.patch1.03 KB

This patch removes the redundant [role=navigation] attribute.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-4
CreditAttribution: mparker17 commented
Status: Needs review » Reviewed & tested by the community

Code looks good, works as advertised.

Looks good to me!

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Reviewed & tested by the community » Needs review

This makes sense to me.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Needs review » Reviewed & tested by the community

oops.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 51efbbf and pushed to 8.x. Thanks!

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Issue tags: +Spark

Adding Spark tag for tracking.

Automatically closed -- issue fixed for 2 weeks with no activity.