Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Task to increase test coverage for \Drupal\Component\Utility\Crypt
.
See #1938068: Convert UnitTestBase to PHPUnit.
Current test coverage: 62.07%
Comment | File | Size | Author |
---|---|---|---|
#9 | crypt-phpunit-2046207-09.patch | 2.78 KB | Mile23 |
#6 | crypt-phpunit-2046207-06.patch | 2.78 KB | Mile23 |
#3 | interdiff.txt | 1.94 KB | jhedstrom |
#3 | crypt-phpunit-2046207-03.patch | 2.21 KB | jhedstrom |
#1 | crypt-phpunit-2046207-01.patch | 2.2 KB | jhedstrom |
Comments
Comment #1
jhedstromThis patch expands coverage to 75.86%. Not sure how to test the missed code, as it largely depends on environment setup, or on testing random strings, which I have not immediate thoughts on how to do.
Comment #2
dawehnerparameters are not camelcased accoring to the drupal code style.
Comment #3
jhedstromRemoved the camel case vars.
Comment #4
dawehnerIt would be cool to have @param and @return for these methods, sorry :(
Comment #5
dawehnerComment #6
Mile23Took out 'static.'
Added @param and @return for methods without them.
Added @group.
Comment #7
Mile23Comment #8
dawehnerNitpick alarm: trailing space left.
Comment #9
Mile23I blame NetBeans. I'll never get used to it.
Meanwhile back in Coda...
Comment #10
dawehnerGreat, thank you!
Comment #11
alexpottCommitted 3b91bd1 and pushed to 8.x. Thanks!
Comment #13
jhedstrom