Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think the only place we are using constants now in views is in FieldPluginBase, these are really just internal to the class, so let's just move them onto the class.
Comments
Comment #1
dawehnerOut of scope and against your own patch.
Comment #2
damiankloip CreditAttribution: damiankloip commentedhehe, I actually think I mixed it with that patch, hence the change. Yes this should be reverted.
Comment #3
dawehner.
Comment #4
thomas.fleming CreditAttribution: thomas.fleming commentedComment #5
thomas.fleming CreditAttribution: thomas.fleming commentedComment #7
damiankloip CreditAttribution: damiankloip commentedThat last patch to seems to actually revert what the issue is trying to do? :)
Comment #8
undertext CreditAttribution: undertext commentedComment #9
undertext CreditAttribution: undertext commentedComment #10
damiankloip CreditAttribution: damiankloip commentedSorry, please see the patch in #0, as that is correct except for the one hunk that dawehner pointed out on #1. For the constant names and use of static:: etc...
Comment #11
undertext CreditAttribution: undertext commentedSorry, i can't understand one thing.
What is the real life reason of using late static binding for this constants?
Comment #12
damiankloip CreditAttribution: damiankloip commentedLook at everywhere else in d8 core, we use static::. You never know what people will do with extending classes.
Comment #13
undertext CreditAttribution: undertext commentedComment #14
dawehnerPerfect!
Comment #15
lokapujyaComment #16
catchCommitted/pushed to 8.x, thanks!