Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Issue tags: +Novice
@@ -279,7 +279,7 @@ public function getElements() {
-      $elements += config('views.settings')->get('field_rewrite_elements');
+      $elements += \Drupal::config('views.settings')->get('field_rewrite_elements');

Out of scope and against your own patch.

damiankloip’s picture

hehe, I actually think I mixed it with that patch, hence the change. Yes this should be reverted.

dawehner’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

.

thomas.fleming’s picture

thomas.fleming’s picture

Status: Needs review » Needs work
damiankloip’s picture

That last patch to seems to actually revert what the issue is trying to do? :)

undertext’s picture

undertext’s picture

Status: Needs work » Needs review
damiankloip’s picture

Sorry, please see the patch in #0, as that is correct except for the one hunk that dawehner pointed out on #1. For the constant names and use of static:: etc...

undertext’s picture

Sorry, i can't understand one thing.
What is the real life reason of using late static binding for this constants?

damiankloip’s picture

Look at everywhere else in d8 core, we use static::. You never know what people will do with extending classes.

undertext’s picture

dawehner’s picture

Perfect!

lokapujya’s picture

Status: Needs review » Reviewed & tested by the community
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.