Not your fault, as I've looked at the code, but it's a shame I guess that when it's run there is not a lot of context information around to pull from.
I'd hoped to be able to have access to the target destination field definition already,
(My use case is trying to rewrite an imported string into an entityreference reference ID, and if I knew the target field definition info I'd be able to do the lookup better)
but I guess I have to do all those api lookups by hand. :-(
I was able to push the module here to give me the 'source' and the 'settings' arrays ... but not the target info.
No action needed here, just a little comment from me.
Comment | File | Size | Author |
---|---|---|---|
#4 | full_item_access-1921976-7111549.patch | 1.85 KB | gaurav.goyal |
#2 | full_item_access-1921976-7111548.patch | 690 bytes | tema |
Comments
Comment #1
meSteHaving to set a default value for empty fields based on another field, I modified php.inc as follow:
to expose the whole $item array.
I think that exposing a more generic object, such as $source, would kill performance with large files.
Tested with a very small 13 cols x 23 rows csv file: worked fine.
I hope this could be useful.
Comment #2
tema CreditAttribution: tema commented+1 for this change. Tested with relatively small web-scraping. Works good to me. No significant performance drop was expected.
Comment #3
gaurav.goyal CreditAttribution: gaurav.goyal commentedGreat Work. Tested with a 5579 rows X 9 cols CSV, works fine. only having some @docblock missing issues will submit the patch after some time
Comment #4
gaurav.goyal CreditAttribution: gaurav.goyal commentedHere is the Patch.
Comment #5
vegantriathleteTook just a cursory look at the patch.
Definitely disagree with changing t() to check_plain()
Comment #6
meSteJust released 1.1 with this feature.
Comment #7
meSte