Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#9 | examples_cron-example_1867662-9.patch | 13.61 KB | wesleydv |
#7 | examples_cron-example_1867662-7.patch | 13.6 KB | wesleydv |
#6 | 1867662-6.patch | 11.8 KB | marvil07 |
#1 | 0001-Port-cron_example-to-D8.patch | 12.44 KB | marvil07 |
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedHere a first functional version!
Please let me know what more needed here.
Comment #2
marvil07 CreditAttribution: marvil07 commentedComment #3
Mile23Thanks, marvil07.
Many references to Drupal 7.
Adopting the structure of a D8 module is great (with lib directory, etc.), but the documentation needs some editorial attention as well.
Comment #4
Mile23You're welcome to submit more patches, but we're holding off on D8 a bit: #1861598: Examples for Drupal 8 needs relatively stable feature set
Comment #5
Mile23Comment #6
marvil07 CreditAttribution: marvil07 commentedminor re-roll with info file to yml, still needs real changes
Comment #7
wesleydv CreditAttribution: wesleydv commentedRewrote the patch to use a form controller and new Drupal 8 function like config mgmt
Comment #8
tsphethean CreditAttribution: tsphethean commentedhook_cron_queue_info should be hook_queue_info and the comment needs updating as this is a new hook in D8.
No full stop on contains
This comment is a little odd
Shouldn't these be got from $config->get()
no newline at end of file?
Comment #9
wesleydv CreditAttribution: wesleydv commentedFixed issues raised by tsphethean
Comment #10
marvil07 CreditAttribution: marvil07 commented@wesleydv: Thanks for the new patch implementing new APIs!
I will try to make a closer look as soon as I fix the tests for other submodules already added to 8.x-1.x, so your patch can be tested by testbot. I only could fix block_example today.
Comment #11
marvil07 CreditAttribution: marvil07 commentedI added the last patch to 8.x-1.x, thanks!
Comment #13
Mile23Note: This module is now very broken because it relies on variable_set().
#2197267: Remove variable_set()/variable_get() from cron_example