Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#27 | 1987720-form_test-controller-27.patch | 1.58 KB | amitgoyal |
#25 | 1987720-form_test-controller-25.patch | 1.5 KB | amitgoyal |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
partyka CreditAttribution: partyka commentedReopening.
Comment #4
partyka CreditAttribution: partyka commented++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
The patch is provided as noted in the terms of the copyright notice.
The form_test_wrapper_callback is converted to use a controller instead of hook_menu
This patch is being submitted by Argonne National Laboratory, August 15, 2013
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comment #5
partyka CreditAttribution: partyka commentedSetting patch to needs review.
Comment #7
partyka CreditAttribution: partyka commentedUpdated patch for line-endings.
Comment #8
dawehnerLet's drop this hook_menu() entry.
Let's add some simple lines.
No need for this change
Comment #9
xjmThanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Comment #10
vijaycs85Re-roll that fixes all review comments in #8
Comment #12
YesCT CreditAttribution: YesCT commentedreroll instructions: https://drupal.org/contributor-tasks/reroll
@partyka, it has been a few months. unassigning. no worries. :)
Comment #13
Sam Hermans CreditAttribution: Sam Hermans commentedI'll check this out
Comment #14
Sam Hermans CreditAttribution: Sam Hermans commentedRe rolled patch agains latest HEAD.
Comment #15
Sam Hermans CreditAttribution: Sam Hermans commentedFixed failing tests
Comment #17
pfrenssenThese can be put in alphabetical order.
This is not a search controller. This can be changed to:
Comment #18
Sam Hermans CreditAttribution: Sam Hermans commentedComment #19
Sam Hermans CreditAttribution: Sam Hermans commentedThank you for your reviewing this .. i adressed your remarks and added them in a seperate interdiff.txt
Comment #21
ianthomas_ukThis conflicts with #2110951: Remove hook_forms() and may even be a duplicate.
Comment #22
xjm19: 1987720-form_test-controller-19.patch queued for re-testing.
Comment #24
xjmComment #25
amitgoyal CreditAttribution: amitgoyal commentedReroll of #19.
Comment #26
Mile23Comment #27
amitgoyal CreditAttribution: amitgoyal commentedRe-roll of #25.
Comment #28
Mile23form_test_wrapper_callback()
went away here: http://cgit.drupalcode.org/drupal/commit/?id=466ef999aeb2f7fde41e3fcd16d...Issue: #2110951: Remove hook_forms()
Thanks, amitgoyal!
Comment #29
Mile23