Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff.txt | 3.61 KB | Mile23 |
#19 | 1987890_19.patch | 6.71 KB | Mile23 |
#17 | 1987890_17_reroll_13.patch | 3.1 KB | Mile23 |
#13 | drupal8.update-module.1987890-13.patch | 5.67 KB | undertext |
#9 | 1987890-9.patch | 5.75 KB | pwolanin |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
disasm CreditAttribution: disasm commentedComment #4
disasm CreditAttribution: disasm commentedattached patch converts to new controller.
Comment #6
disasm CreditAttribution: disasm commentedComment #8
xjmThanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Comment #9
pwolanin CreditAttribution: pwolanin commentedre-roll and change to use ControllerBase to simplify the conversion
Comment #10
xjm9: 1987890-9.patch queued for re-testing.
Comment #12
xjmComment #13
undertext CreditAttribution: undertext commentedComment #14
m1r1k CreditAttribution: m1r1k commentedComment #15
star-szrComment #16
Mile23Related: #1811202: Add missing type hinting to Update module docblocks
Comment #17
Mile23Reroll.
Comment #18
valthebaldCan we remove update_test_mock_page() from update_test.module?
Comment #19
Mile23Done.
Comment #20
valthebaldLooks good now!
Comment #21
alexpottChanges to tests are not frozen and it's good to be getting the final WSCCI conversions done. Committed 4f03557 and pushed to 8.0.x. Thanks!