Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Sticky Edit Actions uses "edit-actions" Id to apply it's functionality to the buttons. Media module uses multiform which doesn't apply ['actions'] for its buttons and because of that "edit-actions" Id is not present. It doesn't provide an alter hook for the form either.
More information can be found here #2065525: Use 'actions' for buttons.
Proposed solution for this problem is to add an alter hook for the multiform in Media module so that Sticky Edit Content module can add ['actions'] for the buttons by itself.
Comment | File | Size | Author |
---|---|---|---|
#12 | media-2067091-12.patch | 744 bytes | binkaster |
#11 | media-2067091-10.patch | 744 bytes | binkaster |
#7 | media-2067091-7.patch | 774 bytes | binkaster |
#1 | media-2067091-1.patch | 963 bytes | binkaster |
Comments
Comment #1
binkaster CreditAttribution: binkaster commentedAttached is a patch that adds alter hook for the multiform.
Comment #2
binkaster CreditAttribution: binkaster commentedComment #4
Elijah LynnWhitespace cleanup and how about this as a comment,
// Allow other modules to alter the form.
Comment #5
Elijah LynnAlso you will need to use the option --relative when generating this patch that is why the patch failed, see the URLs in the patch, they need to be relative to the Media module folder. Also changed version to 2.0 unstable.
Comment #6
Elijah Lynncrosslinking relevant issues:
Comment #7
binkaster CreditAttribution: binkaster commentedAdding the new corrected patch file.
Comment #9
Elijah Lynncd into the modules/media folder and run the command from there with --relative. Looks like you were one level too high up.
Comment #10
Elijah LynnComment #11
binkaster CreditAttribution: binkaster commentedCreated a new patch according to suggestions above.
Comment #12
binkaster CreditAttribution: binkaster commentedChanged patch name to match the comment.
Comment #13
Elijah LynnLooks very good and it works!
All comments should end in a period.
Other than that I tested this with Sticky Edit Actions and it works well with no negative impact on Media module other than making it more flexible.
Comment #14
Elijah LynnComment #16
Elijah LynnHrmm, maybe the patch failed because it was the wrong version. We are actually using 7.x-2.0-unstable7+38-dev
We should probably git clone the latest dev and roll the patch directly against that if this fails again.
Comment #17
Elijah Lynn#12: media-2067091-12.patch queued for re-testing.
Comment #18
aaron CreditAttribution: aaron commentedCommitted to http://drupalcode.org/project/media.git/commit/e68e32a. Just needs to be ported now, I believe. Thanks everyone.
Comment #19
Elijah LynnComment #20
Elijah LynnComment #21
Elijah LynnComment #22
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedClosing this issue as outdated. However, if you think this issue is still important, please let us know and we will gladly re-open it for review.
sincerely,
- the Drupal Media Team