Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of #1971384: [META] Convert page callbacks to controllers and helps towards #1830588: [META] remove drupal_set_title() and drupal_get_title()
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#27 | 1987888-entity_test-controller-27.patch | 3.84 KB | ianthomas_uk |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
robeano CreditAttribution: robeano commentedI'll take entity_test module starting with this issue.
Comment #4
robeano CreditAttribution: robeano commentedI will likely run out of time to work on this patch. Unassigning myself.
Comment #5
disasm CreditAttribution: disasm commentedComment #6
disasm CreditAttribution: disasm commentedfirst pass.
Comment #8
disasm CreditAttribution: disasm commentedChanging _access to _permission since it's not a callback.
Comment #10
xjmThanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Comment #11
vijaycs85Re-roll+ drupal_set_title() update...
Comment #13
vijaycs8511: 1987888-entity_test-controller-11.patch queued for re-testing.
Comment #15
ianthomas_ukRe-roll, resolved conflict in entity_test.module
Comment #18
Wim Leers15: 1987888-entity_test-controller-15.patch queued for re-testing.
Comment #19
ianthomas_uk@Wim Leers have you been looking into this or did you just want fresh test results before you started? I've been having a look this evening, I spotted that the new code is calling entityManager() when I think it should be entityFormBuilder() and was about to test a patch to change that, but can leave you to it if you're already working on it.
Comment #21
ianthomas_ukAs mentioned, entityManager() > entityFormBuilder(). Fixes the tests I've tried locally.
Comment #22
ianthomas_ukComment #23
ianthomas_ukBumping to major since this blocks #1830588: [META] remove drupal_set_title() and drupal_get_title()
Comment #24
rlmumfordDoes entity_test_menu() still exist?
Apart from that question this all looks good to me. Happy to RTBC.
Comment #25
rlmumfordYeah, entity_test_menu() was removed in 8608fed
We should probably update the docblock.
Comment #26
rlmumfordHere's an updated patch.
Comment #27
ianthomas_ukThat was moved to \Drupal\entity_test\Routing\EntityTestRoutes::routes(), this patch puts an appropriate @see on each method, rather than just removing it.
Comment #28
rlmumfordThis looks good to me.
Comment #29
webchickCommitted and pushed to 8.x. Thanks!