Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#23 | drupal8.aggregator-module.1987598-23.patch | 6.94 KB | mparker17 |
#23 | interdiff.txt | 2.13 KB | mparker17 |
#20 | drupal8.aggregator-module.1987598-20.patch | 6.51 KB | disasm |
#20 | interdiff.txt | 867 bytes | disasm |
#18 | drupal8.aggregator-module.1987598-18.patch | 6.54 KB | disasm |
Comments
Comment #1
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedComment #2
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedGo testbot, go!
(Later maybe we should consider #2004022: Move aggregator_test module into its own directory.)
Comment #3
dawehnerIs it just me that this logic is not 100% the same? Dries birthday got added before all the time.
can't we also use false here which then get converted to FALSE?
Comment #4
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedIntresting. Have a look:
Before the patch:
After the patch:
Recorded with Firefox Live Http headers. I don't think I fully understand what's going on here.
Comment #5
ParisLiakos CreditAttribution: ParisLiakos commentedlets just wont fix this
#1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #6
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #7
mparker17I'll help!
Comment #8
mparker17Whoops... @rabellamy is working on these :P
Comment #9
rabellamy CreditAttribution: rabellamy commentedComment #10
rabellamy CreditAttribution: rabellamy commentedMarked #1987600: Convert aggregator_test_redirect() to a new style controller as duplicate of this issue.
Comment #12
dawehnerWhat you should do instead is to create a response object and set all this header onto it and finally just return it.
Comment #13
mparker17*sad trombone* I was going to help convert those drupal_add_http_headers but apparently Chicago Midway doesn't have Wi-Fi. Sorry :(
Comment #14
mparker17Try this...
Comment #16
mparker17#14: drupal8.aggregator-module.1987598-14.patch queued for re-testing.
Comment #18
disasm CreditAttribution: disasm commentedWas missing params on the route for the optional parameters. Also, extending ControllerBase to get access to urlGenerator() and $this->redirect. Renamed methods to testFeed and testRedirect.
Comment #20
disasm CreditAttribution: disasm commentedpassing route to $this->redirect should resolve the last failure.
Comment #21
dawehnerCan we have a little bit of docs on there?
Missing @return
Comment #22
xjmThanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Comment #23
mparker17Try this...
Comment #24
mparker17Whoops... paging Dr. Testbot...
Comment #26
disasm CreditAttribution: disasm commented#23: drupal8.aggregator-module.1987598-23.patch queued for re-testing.
Comment #28
disasm CreditAttribution: disasm commented#23: drupal8.aggregator-module.1987598-23.patch queued for re-testing.
Comment #29
dawehnerA couple of random failures later ...
Comment #30
mparker17XD Thanks!
Comment #31
webchickCommitted and pushed to 8.x. Thanks!