Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#9 | drupal8.url_alter_test.1987892-9.patch | 2.36 KB | disasm |
#9 | interdiff.txt | 824 bytes | disasm |
#7 | drupal8.url_alter_test.1987892-7.patch | 2.28 KB | disasm |
#7 | interdiff.txt | 1.65 KB | disasm |
#4 | drupal8.system-module.1987892-4.patch | 2.14 KB | disasm |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
disasm CreditAttribution: disasm commentedComment #4
disasm CreditAttribution: disasm commentedconversion patch.
Comment #5
dawehnerThis should have a newline in between.
You should return just a response object.
this hook can be removed as it is, because MENU_CALLBACKs are directly replaced with controllers.
Comment #6
dawehner.
Comment #7
disasm CreditAttribution: disasm commentedAttached patch addresses comments in #5.
Comment #8
dawehnerLet's also add a simple @return on there.
Comment #9
disasm CreditAttribution: disasm commentedComment #10
dawehnerThank you.
Comment #11
alexpottCommitted 80d9f5c and pushed to 8.x. Thanks!
At some point we need to replace current_path and request_path with stuff based on Symfony's Request object.
I think we should use the Request to get the currecnt path. The function uses
drupal_container()->get('request')->attributes->get('_system_path')