If a tip's body contains list tags, simpletest throws a warning in regards to @attributes.

CommentFileSizeAuthor
#4 2073875-tour-list-exceptions-FAIL.patch1.92 KBnick_schuch
#4 2073875-tour-list-exceptions-PASS.patch2.74 KBnick_schuch
#1 2073875-1-tourtestbase-modal-tips.patch704 bytesnick_schuch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Assigned: Unassigned » nick_schuch
Status: Active » Needs review
FileSize
2073875-1-tourtestbase-modal-tips.patch704 bytes

Here we go!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Needs work
Issue tags: +Needs tests

We need a test showing the fail

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Title: TourTestBase needs to allows for modal tips » TourTestBase needs to allow for list elements in the body

Actually it's not modal at all. It's list elements in the body of tips. I am endeavouring to write a patch that will expose this.

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Status: Needs work » Needs review
FileSize
2073875-tour-list-exceptions-PASS.patch2.74 KB
2073875-tour-list-exceptions-FAIL.patch1.92 KB

Here are the patches to both confirm the issue and then fix it.

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, 2073875-tour-list-exceptions-PASS.patch, failed testing.

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Status: Needs work » Needs review
Issue tags: +Needs tests

#4: 2073875-tour-list-exceptions-PASS.patch queued for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests +Quick fix

Good to go, has test coverage and fixes the issue

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 37ce9e5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

List tags. Not modal.