line 1355 of sites/all/modules/lightbox2/lightbox2.module. Notice is on this line:

  $output = filter_xss($_POST['string'], $allowed_tags);
CommentFileSizeAuthor
#12 1327556-11.patch613 bytesjoelpittet
#11 1327556-10.patch785 bytesjoelpittet
#9 lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-9.patch1.32 KBmajingas
#8 lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-8.patch1.36 KBmajingas
#7 php_notice-1327556-9635469.patch722 byteskrishna savithraj
#5 lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-5.patch1.43 KBkarenann
#4 lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-4.patch1.43 KBkarenann
#1 lightbox2-1327556-1.patch619 bytesmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Needs review
FileSize
lightbox2-1327556-1.patch619 bytes
Dubs’s picture

Dubs CreditAttribution: Dubs commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

This is still an issue in version 7 and the patch does resolve. Can this be committed?

karenann’s picture

karenann CreditAttribution: karenann commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1

I am still seeing this error though now it's

Notice: Undefined index: string in lightbox2_filter_xss() (line 1557 of /sites/all/modules/lightbox2/lightbox2.module).

Working on a patch to upload shortly.

karenann’s picture

karenann CreditAttribution: karenann commented
FileSize
lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-4.patch1.43 KB
karenann’s picture

karenann CreditAttribution: karenann commented
Status: Needs review » Needs work
FileSize
lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-5.patch1.43 KB

Same thing, just made a mistake in posting. Goal is to get the patch queued for testing.

Matroschker’s picture

Matroschker CreditAttribution: Matroschker commented
Issue summary: View changes

Have the same issue:

Notice: Undefined index: string in lightbox2_filter_xss() (line 1657 of C:\...\sites\all\modules\lightbox2\lightbox2.module).

Using: Lightbox 7.x-1.0-beta1+9-dev

krishna savithraj’s picture

krishna savithraj CreditAttribution: krishna savithraj commented
FileSize
php_notice-1327556-9635469.patch722 bytes

Please test the attached patch for this issue.

majingas’s picture

majingas CreditAttribution: majingas commented
FileSize
lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-8.patch1.36 KB

Edit: Dont use this patch

majingas’s picture

majingas CreditAttribution: majingas commented
FileSize
lightbox2_undefined-index-string-lightbox2-filter-xss_1327556-9.patch1.32 KB

Submitting modified version of karenann's patch that doesn't use sites/all/modules path to work better with makefiles and profiles.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Version: 7.x-1.0-beta1 » 7.x-2.x-dev
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
FileSize
1327556-10.patch785 bytes

The patch in #1 looks a bit cleaner. Just needs to be updated for 7.

How about this patch?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
FileSize
1327556-11.patch613 bytes

Whoops that needed to be a --relative git patch.

  • voleger committed ae29667 on 7.x-2.x 
    Issue #1327556 by karenann, joelpittet, majingas, mikeytown2, krishna...
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Fixed

Looks good.
Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.