[Pull request] Show siblings at deepest level

Hi there Kristiaan, your patch is AWESOME and I've made use of it in Drupal 7 installations, however, I'm wanting to apply it in a drupal 6 installation and the 3rd/4th hunks in menu_block.admin.inc won't patch (appears function menu_block_configure_form and function _menu_block_block_save) are different. I'm trying to sort this out myself atm but you might understand it well enough to be able to help quicker :) if you have the time I'd appreciate some guidance, please.

I've fixed the problem. For 6.x-2.4 (menu_block.admin.inc) you don't appear to need

@@ -436,7 +448,7 @@ function menu_block_configure_form($form, &$form_state) {
   $form['menu-block-wrapper-close'] = array('#markup' => '</div>');
 
   // Set visibility of advanced options.
-  foreach (array('title_link', 'follow', 'follow_parent', 'expanded', 'sort', 'parent_mlid') as $key) {
+  foreach (array('title_link', 'follow', 'follow_parent', 'show_deepest', 'expanded', 'sort', 'parent_mlid') as $key) {
     $form[$key]['#states']['visible'][':input[name=display_options]'] = array('value' => 'advanced');
   }
   if ($config['title_link'] || $follow || $config['expanded'] || $config['sort'] || $config['parent_mlid']) {

So apply the patch as normal and then manually paste the additional line from hunk 4
+ variable_set("menu_block_{$delta}_show_deepest", $edit['show_deepest']);
...into...

function _menu_block_block_save($delta, $edit) {
  variable_set("menu_block_{$delta}_title_link", $edit['title_link']);
  variable_set("menu_block_{$delta}_admin_title", $edit['admin_title']);
  variable_set("menu_block_{$delta}_parent", $edit['parent']);
  variable_set("menu_block_{$delta}_level", $edit['level']);
  variable_set("menu_block_{$delta}_show_deepest", $edit['show_deepest']); /* new addition */
  variable_set("menu_block_{$delta}_follow", $edit['follow']);
  variable_set("menu_block_{$delta}_depth", $edit['depth']);
  variable_set("menu_block_{$delta}_expanded", $edit['expanded']);
  variable_set("menu_block_{$delta}_sort", $edit['sort']);
}

...and voila! I'll continue to test but early indications are good :)

Any way of showing siblings while keeping the Starting level to as "1st level (primary)"?

Just wanted to say your code works beautifully. This should be a must have feature.

More typos

Feature requests by nature are not critical.

Your patch was not working for me when having more than 4 levels. Here I am submitting a new path that works for all levels.

@kristiaanvandeneynde your patch in #1 no longer applies to 7.x-2.x-dev

+++ b/menu_block.module
@@ -335,7 +337,7 @@ function menu_tree_build($config) {
-    menu_tree_prune_active_tree($tree, $config['follow']);
+    menu_tree_prune_active_tree($tree, $config);

This line of code is no longer in the 2.x-dev version

@Jorge Navarro - Is your patch to be combined with the patch in #1?

@kristiaanvandeneynde - Thanks for the quick patch. I applied it and it seems to work as expected.

There is also another patch at #1125154: "Deepest item in the active trail with visible siblings" as option for follow_parent that seems to do the same thing, but doesn't change the module code as much. It doesn't set new variables or change function parameters. Maybe that patch would be better?

Adding another similar issue. #1620298: Add new starting level option "Children of active menu item, and active menu item if no children"

I don't know how, but I tested the one line patch in #1620298: Add new starting level option "Children of active menu item, and active menu item if no children" and it seems to do the same thing as well.

My patch is a new patch. The patch changes the module to show the menu (the previous, with siblings) if you are at deepest level, so when you arrive to deepest level, the menu doesn't disappear.

+++ b/menu_block.module
@@ -641,14 +643,14 @@ function menu_tree_prune_tree(&$tree, $level, $parent_item = FALSE) {
-function menu_tree_prune_active_tree(&$tree, $level) {
+function menu_tree_prune_active_tree(&$tree, $config) {
   module_load_include('inc', 'menu_block', 'menu_block.follow');
-  _menu_tree_prune_active_tree($tree, $level);
+  _menu_tree_prune_active_tree($tree, $config['follow'], $config['show_deepest']);

The only thing I can find is that this is an API change for menu_tree_prune_active_tree(). Would it be better just to add the third parameter like was done to _menu_tree_prune_active_tree() above?

While we could change the API in 7.x-3.x, I don't think we should change a publicly-available API in 7.x-2.x since it has stable releases.

@kristiaanvandeneynde your patch has been working beautifully for me.
However I am now working on a subsite and I can't directly patch the module.
Do you perhaps have any alternative idea on how to get the same results by working on a theme?

I have a patch ready for Drupal 8, but I'm trying to decide where to put it.

I would propose the following three issues be closed as a duplicates because #758184: Show items on same level if active menu level doesn't have children predates all of them and has more followers than any of these others combined. I will put my D8 patch there.

* #1125154: "Deepest item in the active trail with visible siblings" as option for follow_parent
* #1620298: Add new starting level option "Children of active menu item, and active menu item if no children"
* #1650684: [Pull request] Show siblings at deepest level (this issue)