Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#9 drupal-1987576-9.patch3.55 KBmrded
#7 drupal-1987576-7.patch3.49 KBmrded
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

acrollet’s picture

acrollet CreditAttribution: acrollet commented
Assigned: Unassigned » acrollet

taking a look at this today.

acrollet’s picture

acrollet CreditAttribution: acrollet commented
Assigned: acrollet » Unassigned

going to look for a non-test module issue per Larry.

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Closed (won't fix)

wont fix for now
#1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

ayelet_Cr CreditAttribution: ayelet_Cr commented
Status: Closed (won't fix) » Active
Sean Buscay’s picture

Sean Buscay CreditAttribution: Sean Buscay commented
Assigned: Unassigned » Sean Buscay
mrded’s picture

mrded CreditAttribution: mrded commented
Assigned: Sean Buscay » mrded
Issue tags: +LONDON_2013_AUGUST

Working on this as part of London sprint.

mrded’s picture

mrded CreditAttribution: mrded commented
Status: Active » Needs review
FileSize
drupal-1987576-7.patch3.49 KB

Please, take a look my patch.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Needs work

Thanks for the quick re-roll @mrded.

+++ b/core/modules/system/tests/modules/session_test/lib/Drupal/session_test/Controller/SessionTestController.php
@@ -0,0 +1,30 @@
+ * Contains \Drupal\session_test\Controller\SessionTestController.
...
+class SessionTestStartController implements ControllerInterface {

Can we update the class name to the one in comment?

+class SessionTestStartController implements ControllerInterface {

+++ b/core/modules/system/tests/modules/session_test/lib/Drupal/session_test/Controller/SessionTestController.php
@@ -0,0 +1,30 @@
+    return 'session_id:' . $_COOKIE[session_name()] . "\n";

diff --git a/core/modules/system/tests/modules/session_test/session_test.module b/core/modules/system/tests/modules/session_test/session_test.module
index b6e1a53..d003498 100644

we need to use Request.

mrded’s picture

mrded CreditAttribution: mrded commented
Status: Needs work » Needs review
FileSize
drupal-1987576-9.patch3.55 KB

Take a look to new patch.

Status: Needs review » Needs work

The last submitted patch, drupal-1987576-9.patch, failed testing.

disasm’s picture

disasm CreditAttribution: disasm commented
Status: Needs work » Closed (duplicate)

Please work on this here: #1987572: Convert session_test callbacks to a new style controller. There's already a patch that has conversions for all the session_test callbacks. It just needs the tests fixed.