Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#10 drupal-1987574-10.patch1.58 KBmrded
#9 drupal-1987574-8.patch3.64 KBmrded
#7 drupal-1987574-7.patch3.73 KBmrded
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Closed (won't fix)

#1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

ayelet_Cr CreditAttribution: ayelet_Cr commented
Status: Closed (won't fix) » Active
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-4
CreditAttribution: mparker17 commented
Assigned: Unassigned » mparker17

I will help!

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-4
CreditAttribution: mparker17 commented
Assigned: mparker17 » Unassigned

Unassigning myself as @seanbuscay will take care of it.

Sean Buscay’s picture

Sean Buscay CreditAttribution: Sean Buscay commented
Assigned: Unassigned » Sean Buscay
mrded’s picture

mrded CreditAttribution: mrded commented
Issue tags: +LONDON_2013_AUGUST

Working on this as part of London sprint.

mrded’s picture

mrded CreditAttribution: mrded commented
Assigned: Sean Buscay » mrded
Status: Active » Needs review
FileSize
drupal-1987574-7.patch3.73 KB

Please, take a look my path.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/system/tests/modules/session_test/lib/Drupal/session_test/Controller/SessionTestController.php
@@ -0,0 +1,42 @@
+   */

    Can inherit or remove, if we are not doing any in __construct, we can remove it. 

  2. +++ b/core/modules/system/tests/modules/session_test/session_test.routing.yml
@@ -0,0 +1,6 @@
--

    Missing empty line at the end.

mrded’s picture

mrded CreditAttribution: mrded commented
Status: Needs work » Needs review
FileSize
drupal-1987574-8.patch3.64 KB

New version.

mrded’s picture

mrded CreditAttribution: mrded commented
FileSize
drupal-1987574-10.patch1.58 KB

Sorry, forgot to change controller's name.

Status: Needs review » Needs work

The last submitted patch, drupal-1987574-10.patch, failed testing.

disasm’s picture

disasm CreditAttribution: disasm commented
Status: Needs work » Closed (duplicate)

Please work on this here: #1987572: Convert session_test callbacks to a new style controller. There's already a patch that has conversions for all the session_test callbacks. It just needs the tests fixed.