Just a notice: When using the Fences module and overriding the default classes with Fences’ single field-NAME class the BEM style replacements in omega_preprocess_field() are not working.

Adding this in hook_preprocess_field() is fixing it:

$variables['classes_array'] = str_replace('field-', 'field--', $variables['classes_array']);
CommentFileSizeAuthor
#2 omega_wants_bem_classes_also_when_using_fences_module-2027709.patch700 bytescriz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fubhy’s picture

fubhy CreditAttribution: fubhy commented

Can you provide a patch for that?

criz’s picture

criz
he/him
Location Vienna/Austria
CreditAttribution: criz commented
FileSize
omega_wants_bem_classes_also_when_using_fences_module-2027709.patch700 bytes

here is a patch

msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented
Status: Active » Needs work

We were previously using that exact line in field.preprocess.inc, however we replaced it (commit: 5127876) with specific replacements for each, and then were even more specific using preg_replace() (commit: 030d691).

I need to have a think about the best way to target this class, without being to generic (as we were before).

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs work » Fixed

Just committed http://drupalcode.org/project/omega.git/commit/d99d559 which should fix this. I simply improved the regex and turned it into a single one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Issue summary: View changes
Status: Closed (fixed) » Reviewed & tested by the community

This should really be highlighted in the release notes (https://drupal.org/node/2068077 or https://drupal.org/node/2087583 - they seem to list the same issues), as anyone who has written css against older versions will need to update their selectors.

I suggest adding "This release fixes Fences block-element-modifier classes, so field-foo-bar becomes field--foo-bar." above the change list.

I'm not really sure what the appropriate status for this would be, setting as RTBC to hopefully get attention from the maintainers (as it needs to be changed by one of them).

GiorgosK’s picture

GiorgosK
Location Chios, Greece 🇬🇷
CreditAttribution: GiorgosK commented

Just installed fences with latest omega 4 release and it seems FENCES is doing nothing
anybody else sees this ?
EDIT: disregard, I though fences would modify forms as well ...

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Status: Reviewed & tested by the community » Fixed

I'm not a maintainer but I consider this fixed. Cannot see anything more to do.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.