Remove Unused local variable $key from /core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php

Thanks for the patch!

Reviewed and this patch looks good, except I think that the declaration of $fields variable at the start of Sql class could be cleaned up? Since after the patch the use (or in this case the unuse) of the variable is removed from the code completely.

Wondering if this chunk could be cleaned up as well? Starting at row 77 after applying the patch:

  /**
   * An array of fields.
   */
  var $fields = array();

I was probably wrong about removing the $fields completely. I think the first patch you did will work fine in this case as it removes the unused variable issue here.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php
@@ -73,12 +73,6 @@ class Sql extends QueryPluginBase {
-

at least $this->fields is 100% used in the class.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php
@@ -1227,9 +1227,6 @@ public function query($get_count = FALSE) {
 
-    $joins = $where = $having = $orderby = $groupby = '';
-    $fields = $distinct = array();

This change looks odd but these variables are indeed not needed.

Committed and pushed to 8.x. Thanks!