Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

ayelet_Cr CreditAttribution: ayelet_Cr commented
Status: Closed (won't fix) » Active
disasm’s picture

disasm CreditAttribution: disasm commented
Assigned: Unassigned » disasm
Sean Buscay’s picture

Sean Buscay CreditAttribution: Sean Buscay commented
Assigned: disasm » Sean Buscay
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue tags: +LONDON_2013_AUGUST

Working on this as part of London sprint.

mrded’s picture

mrded CreditAttribution: mrded commented
Status: Active » Postponed (maintainer needs more info)

I just noticed that drupal_session_will_start() doesn't exist at all.

/**
 * Menu callback, stores a value in $_SESSION['session_test_value'] without
 * having started the session in advance.
 */
function _session_test_set_not_started() {
  if (!drupal_session_will_start()) {
    $_SESSION['session_test_value'] = t('Session was not started');
  }
}
disasm’s picture

disasm CreditAttribution: disasm commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

Please work on this here: #1987572: Convert session_test callbacks to a new style controller. There's already a patch that has conversions for all the session_test callbacks. It just needs the tests fixed.