Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#12 | 2049085-12.patch | 4.71 KB | damiankloip |
#12 | interdiff-2049085-12.txt | 740 bytes | damiankloip |
#9 | 2049085-7.patch | 4.6 KB | damiankloip |
#9 | interdiff-2049085-7.txt | 2 KB | damiankloip |
#5 | 2049085-5.patch | 4.35 KB | damiankloip |
Comments
Comment #1
dawehnerLet's also inject the translator.
Comment #2
damiankloip CreditAttribution: damiankloip commentedComment #3
dawehnerThank you!
Comment #5
damiankloip CreditAttribution: damiankloip commentedThis should fix that.
Comment #6
dawehnerIs there a good reason why we don't use the normal single calls multiple thing as in most other derivative classes?
Comment #7
ParisLiakos CreditAttribution: ParisLiakos commented$this->translationManager->translate() should be $this->t() or the string wont be picked up for parsing.
see #2019679: Support for Drupal 8 $this->t()
Maybe we should add a
DerivativeBase
class for this, similar toFormBase
andControllerBase
, but here at least, we should just add a protected t() method and use this insteadComment #8
ParisLiakos CreditAttribution: ParisLiakos commentedalso see AggregatorCategoryBlock
Comment #9
damiankloip CreditAttribution: damiankloip commentedI guess we will have to at some point. This whole base class thing is getting crazy.
@dawehner: It's a good question, and I guess it would pretty much load all of them at one point anyway, then cache the definitions? I think we should make a follow up to change that though?
Comment #10
dawehnerI am fine with doing that on a followup.
Comment #11
alexpottbasePluginId should be declared as a protected property on the class.
Comment #12
damiankloip CreditAttribution: damiankloip commentedThere we go.
Comment #13
dawehnerNice!
Comment #14
alexpottCommitted f7a4182 and pushed to 8.x. Thanks!
Comment #15
kim.pepperAs a followup, would it be worthwhile moving db calls to the FeedStorageController, and removing the db queries and dependency on the database from here?
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedsure, moving everything to entity storage is always better than raw sql queries
Comment #17
kim.pepperCreated follow up: #2085197: Follow up: Move db queries in AggregatorFeedBlock to FeedStorageController
Comment #18
damiankloip CreditAttribution: damiankloip commentedSeems like a good idea to me!
Comment #19.0
(not verified) CreditAttribution: commentedadded followup