Rubik RTL is broken. there are issues in following:

  • Primary tabs
  • Breadcrumbs
  • Configuration page menu float
  • shortcut menu float

and a few minor icon issues.

CommentFileSizeAuthor
#13 rubik-rtl_issues_fix-1849790-13.patch2.44 KBsinasalek
#12 rubik-rtl_issues_fix-1849790-12.patch0 bytessinasalek
#11 rubik-rtl-fix.patch2.13 KBsinasalek
#10 rubik-rtl-fix.patch2 KBsinasalek
#3 rubik-1849790-cssrtl-3.patch9.16 KBHadi Farnoud
#2 Rubik-rtl-1849790-2.patch24.7 KBHadi Farnoud
#1 Rubik-rtl-1849790-1.patch11.52 KBHadi Farnoud
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Hadi Farnoud’s picture

Hadi Farnoud CreditAttribution: Hadi Farnoud commented
FileSize
Rubik-rtl-1849790-1.patch11.52 KB

bleed-rtl.png was necessary. It's included in the patch. let me know if you need the actual file

Hadi Farnoud’s picture

Hadi Farnoud CreditAttribution: Hadi Farnoud commented
FileSize
Rubik-rtl-1849790-2.patch24.7 KB

removed /docroot dir from the patch

Hadi Farnoud’s picture

Hadi Farnoud CreditAttribution: Hadi Farnoud commented
FileSize
rubik-1849790-cssrtl-3.patch9.16 KB

I followed http://drupal.org/node/1054616 for creating a drupal friendly patch.

Can't delete previous posts.

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented

Committed: fba30e0

Thanks!

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Status: Needs review » Fixed

Forgot status.

Automatically closed -- issue fixed for 2 weeks with no activity.

sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
Issue summary: View changes

There are still several CSS rtl issues :
style-rtl.css

#branding {
    clear: both;
}

.tabs {
    right: auto;
    left: 0px;
}

.views-exposed-form label {
    white-space: nowrap;
}
sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
Version: 7.x-4.0-beta8 » 7.x-4.1
sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
Status: Closed (fixed) » Active
sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
FileSize
rubik-rtl-fix.patch2 KB

Here is a new patch against dev which fixes several important issues

sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
FileSize
rubik-rtl-fix.patch2.13 KB

Here is another one to fix message issues

sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
Version: 7.x-4.1 » 7.x-4.x-dev
Status: Active » Needs review
FileSize
rubik-rtl_issues_fix-1849790-12.patch0 bytes

reroll against head

sinasalek’s picture

sinasalek CreditAttribution: sinasalek commented
FileSize
rubik-rtl_issues_fix-1849790-13.patch2.44 KB

Attaching the correct file

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Status: Needs review » Fixed

Committed. Thanks!

osiengine’s picture

osiengine CreditAttribution: osiengine commented

Hi,
we completed RTL version of Rubik admin theme.
you can see that here

Hadi Farnoud’s picture

Hadi Farnoud CreditAttribution: Hadi Farnoud commented

that's cool @osiengine

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sinasalek’s picture

sinasalek CreditAttribution: sinasalek at Practicalidea commented