Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#18 | drupal8.error_test.1987700-18.patch | 8.92 KB | disasm |
#18 | interdiff.txt | 1.05 KB | disasm |
#16 | drupal8.error_test.1987700-16.patch | 9.58 KB | disasm |
#16 | interdiff.txt | 940 bytes | disasm |
#13 | drupal8.error_test.1987700-13.patch | 9.74 KB | disasm |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
disasm CreditAttribution: disasm commentedComment #4
disasm CreditAttribution: disasm commentedComment #5
disasm CreditAttribution: disasm commentedattached patch converts all routes in error_test module and fixes the error messages the tests are looking for.
Comment #7
disasm CreditAttribution: disasm commentedattached patch with interdiff fixes remaining test failures.
Comment #8
dawehnerLet's simply extend the ControllerBase, so need for this boilerplate for tests.
Comment #9
disasm CreditAttribution: disasm commentedrenamed Controllers -> Controller.
Removed boilerplate in favor of $this->container->get
Comment #11
disasm CreditAttribution: disasm commentedAttached patch fixes missing ;
Comment #13
disasm CreditAttribution: disasm commentedForgot error handlers were keying off of the class name. That's fixed too now.
Comment #14
disasm CreditAttribution: disasm commentedComment #15
dawehnerLet's remove that :)
Comment #16
disasm CreditAttribution: disasm commentedremoved!
Comment #17
jibranThere is one more.
Comment #18
disasm CreditAttribution: disasm commentedremoved!
Comment #19
Crell CreditAttribution: Crell commentedQuick, before core changes again. :-)
Comment #20
Crell CreditAttribution: Crell commented#18: drupal8.error_test.1987700-18.patch queued for re-testing.
Comment #21
webchickCommitted and pushed to 8.x. Thanks!