Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
So we aren't replicating the same code on every tour test we should set the seven theme as the admin theme in TourTestBasic.
Comments
Comment #1
nick_schuch CreditAttribution: nick_schuch commentedHere we go!
Comment #2
larowlanUse $this->container->get('config.factory')->get('system.theme')->set('admin', 'seven')->save() instead
Comment #3
nick_schuch CreditAttribution: nick_schuch commentedNow with tests™
Comment #4
larowlanShould we add the controller just to avoid confusion? Not sure on precedence here.
Other than that, looks ok, I guess the local action could be declared in yml instead of hook_menu() but I'm not sure where thats at yet.
Comment #5
larowlanSorry
Drupal\tour_test\Controller\TourTestController::tourTest1
already exists.As discussed in irc, pwolanin would prefer new local actions use yml instead of hook_menu, makes #2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit simpler
Comment #6
nick_schuch CreditAttribution: nick_schuch commentedAs per discussion in IRC. We need to use a yml implementation over hook_menu. Here is the reroll.
Comment #7
larowlanunless bot disagrees
Comment #8
alexpottPatch no longer applies.
Comment #9
nick_schuch CreditAttribution: nick_schuch commentedThanks alexpott! Rerolled. Selector change in the TourTest that are not required anymore.
Comment #10
larowlanback we go
Comment #11
webchickCommitted and pushed to 8.x. Thanks!