Part of #2072251: [meta] Modernize forms to use FormBase

Updated: Comment #N

Problem/Motivation

Now that #2059245: Add a FormBase class containing useful methods is in, I was looking at old forms that have empty validateForm() methods, or still use Drupal::service() or t().

Proposed resolution

Convert existing FormInterface forms to extend FormBase

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 simpletest_forms-2078007-1.patch697 bytesplopesc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented
Status: Active » Needs review
FileSize
simpletest_forms-2078007-1.patch697 bytes

Simpletest forms included an empty call to validateForm(). Apart form that, it looks good.

Regards.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Does it extends formbase?

plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc commented

Yep ;)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 5f9ca4d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.