Replace user_access() calls with $account->hasPermission() in edit module [#2061983]

Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

user_access() got converted to a method on the user/accountInterface

Comment	File	Size	Author
#7	drupal-edit_replace_user_access-2061983-7.patch	435 bytes	rhm5000
#7
#7	interdiff-2061983-1-7.txt	485 bytes	rhm5000
#1	drupal-edit_replace_user_access-2061983.patch	460 bytes	InternetDevels
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

InternetDevels CreditAttribution: InternetDevels commented 10 August 2013 at 14:37

Status:

Active

» Needs review

File	Size
drupal-edit_replace_user_access-2061983.patch	460 bytes

Pretty simple one.

Comment #2

10 August 2013 at 17:40

Status:	Needs review	» Needs work
Issue tags:	-CodeSprintCIS

The last submitted patch, drupal-edit_replace_user_access-2061983.patch, failed testing.

Comment #3

InternetDevels CreditAttribution: InternetDevels commented 10 August 2013 at 18:37

Status:

Needs work

» Needs review

#1: drupal-edit_replace_user_access-2061983.patch queued for re-testing.

Comment #4

10 August 2013 at 21:29

Status:	Needs review	» Needs work
Issue tags:		+CodeSprintCIS

The last submitted patch, drupal-edit_replace_user_access-2061983.patch, failed testing.

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost commented 29 August 2013 at 16:53

Component:

user system

» edit.module

+++ b/core/modules/edit/edit.module
@@ -53,7 +53,7 @@ function edit_permission() {
+  if (!Drupal::request()->attributes->get('_account')->hasPermission('access in-place editing')) {

Use Drupal::currentUser() service https://drupal.org/node/2032447