don't export internal / automatically generated flag properties [#2059967]

Properties such as 'errors' and 'module' are getting exported. They should not be.

Comment	File	Size	Author
#3	flags_export_after_patch.txt	783 bytes	shabana.navas
#3	flags_export_before_patch.txt	816 bytes	shabana.navas
#2	2059967.flag_.flag-properties-dont-export.patch	1.42 KB	joachim
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joachim CreditAttribution: joachim commented 8 August 2013 at 18:21

'module' is intentionally exported:

      // Even though Flag adds the module name itself later, we add the module
      // name here for reference by other modules (such as Features).
      $new_flag['module'] = $module;

Comment #2

joachim CreditAttribution: joachim commented 8 August 2013 at 18:45

Status:

Active

» Needs review

File	Size
2059967.flag_.flag-properties-dont-export.patch	1.42 KB

Figured this bit of the code could use a little clean-up at the same time.

Comment #3

shabana.navas CreditAttribution: shabana.navas commented 20 August 2013 at 06:35

Status:

Needs review

» Reviewed & tested by the community

File	Size
flags_export_before_patch.txt	816 bytes
flags_export_after_patch.txt	783 bytes

I have tested this now and I can confirm it works. I have attached the before and after versions of the export. The original exported the 'errors' array. However, after the patch was applied, the 'errors' array, as expected, was not exported.