Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/locale/tests/modules/locale_test/locale_test.module

Line 48: Unused local variable $base_url

CommentFileSizeAuthor
#3 drupal-core-remove-unused-local-variable-2080509.patch673 bytesmrsinguyen
#1 drupal-core-remove-unused-local-variable-2080369.patch553 bytesmrsinguyen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Active » Needs review
FileSize
drupal-core-remove-unused-local-variable-2080369.patch553 bytes

Attached patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Needs work

Patch is for a different variable in statistics.tokens.inc.

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Needs work » Needs review
FileSize
drupal-core-remove-unused-local-variable-2080509.patch673 bytes

Sorry, added another patch.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs review » Reviewed & tested by the community

#3 is RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.