Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up of #1497374: Switch from Field-based storage to Entity-based storage. those constants should move to where they are used, this is currently causing trouble in #1776830: [META-1] Installation and uninstallation of configuration provided by a module that belongs to another module's API.
Comment | File | Size | Author |
---|---|---|---|
#14 | load-constants-2079011-14.patch | 20.34 KB | alexpott |
#14 | diff-8-14.txt | 739 bytes | alexpott |
#8 | 6-8-interdiff.txt | 1.15 KB | alexpott |
#8 | load-constants-2079011-8.patch | 20.26 KB | alexpott |
#6 | load-constants-2079011-6.patch | 19.81 KB | Berdir |
Comments
Comment #1
BerdirThere's one instance where I'm not sure what it is, see @todo.
Also weird, the storage uses this constant only internally (except field stuff), but EFQ uses it publicly, with a different meaning (load the revision vs query all the revisions). I think it would be better to create separate constants here.
Comment #3
BerdirMissed two instances too aggressive with deleting...
Comment #4
BerdirTagging.
Comment #6
BerdirMore costant fixes.
Comment #7
BerdirComment #8
alexpottWe can just use the constants properly here
Comment #9
swentel CreditAttribution: swentel commentedLooks good now.
Comment #11
alexpott#8: load-constants-2079011-8.patch queued for re-testing.
Comment #12
swentel CreditAttribution: swentel commentedLooks still ok :)
Comment #13
yched CreditAttribution: yched commentedThanks folks ! I'm fine with this getting in to clean obvious scope issues, but I opened #2081513: Deprecate FIELD_LOAD_* constants for more thoughts on those constants.
Side note: this code looks wrong / broken anyway, see #2081533: Views "group by" on "Field API" fields broken
Comment #14
alexpottPatch no longer applies :) rerolled - I'm all for getting this is and then working out if we can do without them
The interdiff was empty :) so attaching diff that shows a line that's unchanged by this patch has been changed.
Comment #15
catchCommitted/pushed to 8.x, thanks!
Needs a change notice.
Comment #16
jibranComment #17
alexpottChange notice created: https://drupal.org/node/2082357
Comment #19
xjmUntagging. Please remove the tag when the change notification task is completed.