Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up for #1825896-42: Add module owner to plugin data on handlers
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -54,12 +54,14 @@ class Comment extends WizardPluginBase {
- 'field' => 'status'
+ 'field' => 'status',
+ 'provider' => 'user'
...
'field' => 'status',
+ 'provider' => 'user',
This change is wrong!
Comment | File | Size | Author |
---|---|---|---|
#4 | fix-provider-keys-for-comment-wizard-2039677-4.patch | 774 bytes | lokapujya |
#2 | followup-2039677-2.patch | 777 bytes | lokapujya |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedtagging
Comment #2
lokapujyaI think we just want to change the provider to be 'comment'.
Comment #3
damiankloip CreditAttribution: damiankloip commentedChanging the title, that is just not helpful, the fact that it's a followup should not be the main point :)
Patch is looking good, but:
This filter handler is not provided by comment module but by node.
Comment #4
lokapujyaUpdated as said in #3.
Comment #5
lokapujyaComment #6
damiankloip CreditAttribution: damiankloip commentedLooks good.
Comment #7
alexpott#2094839: Wizard should use the API like ViewExecutable::addItem to build the view is going to remove these protected properties in favour of using the API.
Committed b3b073e and pushed to 8.x. Thanks!