Follow-up for #1825896-42: Add module owner to plugin data on handlers

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -54,12 +54,14 @@ class Comment extends WizardPluginBase {
-      'field' => 'status'
+      'field' => 'status',
+      'provider' => 'user'
...
       'field' => 'status',
+      'provider' => 'user',

This change is wrong!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

Issue tags: +Novice

tagging

lokapujya’s picture

Assigned: Unassigned » lokapujya
Status: Active » Needs review
FileSize
777 bytes

I think we just want to change the provider to be 'comment'.

damiankloip’s picture

Title: Follow-up: Add module owner to plugin data on handlers » Fix 'provider' keys for comment wizard default filter definitions
Status: Needs review » Needs work

Changing the title, that is just not helpful, the fact that it's a followup should not be the main point :)

Patch is looking good, but:

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -55,13 +55,13 @@ class Comment extends WizardPluginBase {
     'status_node' => array(
...
+      'provider' => 'comment',

This filter handler is not provided by comment module but by node.

lokapujya’s picture

Updated as said in #3.

lokapujya’s picture

Status: Needs work » Needs review
damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

#2094839: Wizard should use the API like ViewExecutable::addItem to build the view is going to remove these protected properties in favour of using the API.

Committed b3b073e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.