Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
Now that _title can be added to the route definition we realized that it does not work in connection with forms.
The problem is that it does not use the same code path.
Proposed resolution
For now add the _title to the separate codepath as well.
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#13 | title-FAIL.patch | 1.31 KB | dawehner |
#13 | title.patch | 6.3 KB | dawehner |
#12 | title-2068437-12.patch | 4.8 KB | dawehner |
#10 | title-2068437-10.patch | 2.79 KB | dawehner |
#8 | form_title-2068437-8.patch | 3.07 KB | pwolanin |
Comments
Comment #1
dawehner.
Comment #2
dawehner.
Comment #3
aspilicious CreditAttribution: aspilicious commentedFixes the problems I had
Comment #4
webchickNo tests...
Comment #5
dawehnerI had added the tag :p
Comment #6
aspilicious CreditAttribution: aspilicious commented:s srry webchick. I talked about those with dawehner but totally forgot.
Dawehner it's the route one that will fail not the one build with the render array.
Comment #7
dawehnerOh, this is maybe just broken on old menu router items? Does your route implement hook_menu and page callback?
Comment #8
pwolanin CreditAttribution: pwolanin commentedper #2032535: Resolve 'title' using the route and render array we shoudl also have _title_callback. Also, the code was in the wrong section of the conditional.
however, parallel work is hapenning on the vire controller yu Crell, so postponing any test addition
Comment #9
dawehnerSorry but the title callback is out of scope of this issue, let's do one step after the other.
Comment #10
dawehner.
Comment #11
Gábor HojtsyLooks great and blocks converting things to remove drupal_set_title() from core (and contribs). Eg. I ran into this with #2070055: drupal_set_title() is deprecated. Agreed we don't need to support title callback as core does not do it either.
Comment #12
dawehnerThe problem is that the title issue was not tested with overlay enabled. I think we have to add an explicit test for that.
Comment #13
dawehnerAdding a test for overlay to show the failure.
Comment #14
YesCT CreditAttribution: YesCT commentedI think it has tests now. Any others?
Comment #15
Gábor HojtsyThanks for covering overlay. Looks good for me :)
Comment #16
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.