Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/system/lib/Drupal/system/Tests/File/ReadOnlyStreamWrapperTest.php
Line 54: Unused local variable $instance
Comment | File | Size | Author |
---|---|---|---|
#2 | drupal-core-remove-unused-local-variable-2080333_2.patch | 1.09 KB | lorique |
#1 | drupal-core-remove-unused-local-variable-2080333.patch | 752 bytes | mrsinguyen |
Comments
Comment #1
mrsinguyen CreditAttribution: mrsinguyen commentedComment #2
lorique CreditAttribution: lorique commentedIgnore my patch.. i completely misunderstood what was going on in that file. Brain fart on my part..
Comment #3
lorique CreditAttribution: lorique commentedThis works as intended. I misunderstood that it was a test, so ofc you need to test the method you are testing..
Patch in #1 is the correct patch, please ignore/delete my patch in #2.
Patch #1 is reviewed and tested by the community. Thank you for your patch @mrsinguyen
Comment #5
lorique CreditAttribution: lorique commentedSee #3
Comment #6
catchCommitted/pushed to 8.x, thanks!
Comment #7
tstoecklerI don't see how that line contributes anything to the test now. I think the patch in #2 is actually correct (excluding the .htaccess change).
Comment #8
lorique CreditAttribution: lorique commentedYeah i referred to patch in #2, which is the correct one. I assume Catch used the one in #2. My patch was woefully misguided, but i was unable to delete it.
Comment #9
SeyV CreditAttribution: SeyV commentedThis has been committed. Fixing status