Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
We currently do define static page titles on the routes definition using _title. Sadly this never get's translated.
Proposed resolution
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#16 | page_title-2084057-16.patch | 5.17 KB | dawehner |
#13 | page_title-2084057-13.patch | 5.17 KB | dawehner |
#13 | interdiff.txt | 628 bytes | dawehner |
#10 | page_title-2084057-10.patch | 5.14 KB | dawehner |
#10 | interdiff.txt | 661 bytes | dawehner |
Comments
Comment #1
dawehnerThere we go
Comment #3
dawehnerWrong patch ...
Comment #4
dawehnerWrong patch ...
Comment #5
pwolanin CreditAttribution: pwolanin commenteddisables 2 tests:
Comment #6
dawehnerThere we go.
Comment #7
pwolanin CreditAttribution: pwolanin commentedThis looks good - should have been translated from the start.
Comment #8
pwolanin CreditAttribution: pwolanin commentedComment #9
aspilicious CreditAttribution: aspilicious commentedDurpal ==> intentional?
Comment #10
dawehner.
Comment #11
pwolanin CreditAttribution: pwolanin commentedThat's the way I might tend to type it :) but looks better now.
Comment #12
webchick(nitpick) That comment needs to be a sentence ending with a period, but...
How is that actually translating anything? Is the comment wrong, or the code?
Comment #13
dawehnerOh the comment is just stupid, here some a better one.
Comment #14
pwolanin CreditAttribution: pwolanin commentedI find
protected $translationManager;
a little odd as the variable name, but already used all over core.Comment #16
dawehnerReupload to not destroy the testrun.
Comment #17
webchickCommitted and pushed to 8.x. Thanks!