Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
FieldInstance::delete() removes the instance from EntityDisplays for all view modes, but only for the 'default' form mode
Comment | File | Size | Author |
---|---|---|---|
#9 | 2041225-9.patch | 5.87 KB | swentel |
#9 | interdiff.txt | 690 bytes | swentel |
#7 | 2041225-7.patch | 5.84 KB | swentel |
#7 | interdiff.txt | 1.7 KB | swentel |
#5 | 2041225-5.patch | 5.92 KB | swentel |
Comments
Comment #1
andypostIt would really helpful to have a helper to list modes per entity type
Comment #2
yched CreditAttribution: yched commentedtagging
Comment #3
swentel CreditAttribution: swentel commentedThis should do it. Will look for tests later, because it seems the entity display tests are actually not working properly.
Comment #4
swentel CreditAttribution: swentel commentedSome additional tests first for entity display because they were passing without knowing. I've added an explicit check to see whether the component exists or not. Interdiff is between fail and pass.
Comment #5
swentel CreditAttribution: swentel commentedAnd now with form display tests too. Note that I've added a form mode alter in entity_test module so I could test multiple form modes.
Comment #6
yched CreditAttribution: yched commentedThanks, looks correct. Just nitpicks on visual review:
Minor: plural / singular mismatch (same in the other class)
Minor: missing empty line after last method.
Comment #7
swentel CreditAttribution: swentel commentedCleaned up.
Comment #9
swentel CreditAttribution: swentel commentedAh, entity storage of course.
Comment #10
yched CreditAttribution: yched commentedThanks!
RTBC if green.
Comment #11
alexpottCommitted 477cb6e and pushed to 8.x. Thanks!