Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
need reviews
Great — thanks! :)
Sorry folks postponing on #2062151: Create a current user service to ensure that current account is always available.
Garbar, #2062151: Create a current user service to ensure that current account is always available was finished and committed two days ago. Would you like to pick this up again? :)
.
Rerolling after #2062151: Create a current user service to ensure that current account is always available:
Looks nice to go
+++ b/core/modules/editor/lib/Drupal/editor/Plugin/InPlaceEditor/Editor.php @@ -68,7 +68,7 @@ protected function textFormatHasTransformationFilters($format_id) { + $user = \Drupal::currentUser(); ... $manager = \Drupal::service('plugin.manager.editor');
Not sure why the dependencies are not injected here but it was before the patch
This class is from before the proper interfaces for that were finalized IIRC. I'd like to see the conversion happening here, but you're right, that's out of scope for this particular issue.
RTBC+1
Committed 51811d8 and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
Garbar CreditAttribution: Garbar commentedneed reviews
Comment #2
Wim LeersGreat — thanks! :)
Comment #3
catchSorry folks postponing on #2062151: Create a current user service to ensure that current account is always available.
Comment #4
Wim LeersComment #5
Wim LeersGarbar, #2062151: Create a current user service to ensure that current account is always available was finished and committed two days ago. Would you like to pick this up again? :)
Comment #6
Wim Leers.
Comment #7
m1r1k CreditAttribution: m1r1k commentedRerolling after #2062151: Create a current user service to ensure that current account is always available:
Comment #8
andypostLooks nice to go
Not sure why the dependencies are not injected here but it was before the patch
Comment #9
Wim LeersThis class is from before the proper interfaces for that were finalized IIRC. I'd like to see the conversion happening here, but you're right, that's out of scope for this particular issue.
RTBC+1
Comment #10
alexpottCommitted 51811d8 and pushed to 8.x. Thanks!