See for documentation.

The tag value contains three comma-separated parameters; I'm not completely familiar with the Meta Tag API yet, but I think it would be ideal if these were implemented as separate fields and then combined automatically.

#5 smartappbanners-2085747.patch2.33 KBjazzslider
#3 smartappbanners-2085747.patch2.75 KBjazzslider
#1 smartappbanners-2085747.patch2.76 KBjazzslider
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]


Status:Active» Needs review
new2.76 KB
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

The attached patch implements a very basic version of this. I did not, unfortunately, see a way to implement the three named parameters as separate fields, so those using this tag will have to enter the entire string as defined in the docs. That's probably acceptable to most people who would use this.

Status:Needs review» Needs work

Shouldn't it be
<meta name="apple-itunes-app" content="app-id=#" />

instead of

<meta property="apple-itunes-app" content="app-id=#" />

Issue summary:View changes
new2.75 KB

Indeed it should —thanks for the catch, I've updated the patch accordingly.

I think this needs some a little further work:

  • Please don't provide a 160 character long URL as part of the help text :) This should be the URL of a link, e.g. "Parameters for configuring the [link]Smart App Banner[/link]."
  • I don't think you need the custom theme function, the default should work.

new2.33 KB

Please see my latest patch, which implements your recommendations.