Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Facilitates communication between Drupal and SMS gateway TurboSMS.
Links
- Project: https://drupal.org/sandbox/Vik/1993102
- Clone: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Vik/1993102.git turbosms
Comment | File | Size | Author |
---|---|---|---|
#5 | parreview1.png | 56.4 KB | pgautam |
#5 | parreview2.png | 44.1 KB | pgautam |
#2 | turbosms-7.x-1.01-alpha1.zip | 18.04 KB | Vik |
turbosms-7.x-1.0-alpha1.tar_.gz | 16.79 KB | Vik |
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
Vik CreditAttribution: Vik commentedComment #3
pgautam CreditAttribution: pgautam commentedHi Vik,
Please put it in the git repository and provide public link for download.
Thanks,
Paritosh Gautam
Comment #3.0
Vik CreditAttribution: Vik commentedAdd "git clone --branch master http://git.drupal.org/sandbox/Vik/1993102.git turbosms"
Comment #4
Vik CreditAttribution: Vik commentedHi Paritosh Gautam,
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Vik/1993102.git turbosms
Thanks, Vitaliy Sytnik
Comment #5
pgautam CreditAttribution: pgautam commentedHi,
Please find attached ventral comments please fix these in priority.
Thanks,
Paritosh Gautam
Comment #6
Vik CreditAttribution: Vik commentedCan be false operation?
FILE: /var/www/drupal-7-pareview/pareview_temp/turbosms.admin.inc
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
79 | WARNING | Unused variable $k.
--------------------------------------------------------------------------------
Comment #7
Vik CreditAttribution: Vik commentedIn the git repository and provide public link for download.
Comment #8
Vik CreditAttribution: Vik commentedComment #9
Vik CreditAttribution: Vik commentedComment #10
davidmac CreditAttribution: davidmac commentedHi,
It seems as if you've put a lot of work into this module. I have just one or two suggestions.
You've inserted TurboSMS as it's own 'Package' in your .info file, but packages are really categories such as 'Search', 'Development' etc.
Unless you have sub-modules, its worth considering if this falls into another category following the guidelines.
https://drupal.org/node/542202
https://groups.drupal.org/node/97054
On first load, the module throws up several errors:
Notice: Undefined index: turbosms in turbosms_admin_gateway() (line 17 of /var/www/devdavid/sites/all/modules/mysite/turbosms/turbosms.admin.inc).
Have you looked at these?
There is no hook_help() and there is no path to the configuration options in your .info file. And the project page is thin, as is the documentation:
https://drupal.org/node/7765
Comment #11
Jay.Chen CreditAttribution: Jay.Chen commented1. Should use placeholder in t function. e.g.
t('Id messages : ') . $node->sid should be changed to t('Id messages : !sid', array('!sid' => $node->sid)).
If you want to encode string, you should use t('Id messages : @sid', array('@sid' => $node->sid))
2. Line 342, should change 'Submit' to t('Submit').
3. Lines 240 and 241, you should use t function to wrap the string.
Comment #11.0
Jay.Chen CreditAttribution: Jay.Chen commentedmove "master -> 7.x-1.x"
Comment #12
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.