Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

Status: Active » Closed (won't fix)

Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.

ayelet_Cr’s picture

Status: Closed (won't fix) » Active
mparker17’s picture

Assigned: Unassigned » mparker17

I'll help!

mparker17’s picture

Assigned: mparker17 » Unassigned
Status: Active » Needs review
FileSize
3.3 KB

Try this...

dawehner’s picture

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -59,4 +59,18 @@ public function typeLinkActiveClass() {
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
...
+    drupal_set_title('Test querystring');
...
+    return '';

drupal_set_title can be replaced by return array('#title' => 'Test querystring'); If we do that, just put a @return statement in there as well.

dawehner’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -59,4 +59,18 @@ public function typeLinkActiveClass() {
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
...
+    drupal_set_title('Test querystring');
...
+    return '';

drupal_set_title can be replaced by return array('#title' => 'Test querystring'); If we do that, just put a @return statement in there as well.

mparker17’s picture

Status: Needs work » Needs review
FileSize
1.51 KB
3.29 KB

Try this...

dawehner’s picture

+++ b/core/modules/system/tests/modules/common_test/common_test.routing.yml
@@ -4,3 +4,10 @@ common_test_l_active_class:
+  pattern: 'common-test/query-string'

Sorry, pattern should start with "/"

mparker17’s picture

Status: Needs review » Needs work

K

xjm’s picture

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

mparker17’s picture

Status: Needs work » Needs review
FileSize
670 bytes
3.29 KB

Try this...

mparker17’s picture

Try this...

Status: Needs review » Needs work
Issue tags: -WSCCI-conversion

The last submitted patch, drupal8.system-module.1987656-11.patch, failed testing.

mparker17’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal8.system-module.1987656-11.patch, failed testing.

mparker17’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +WSCCI-conversion

The last submitted patch, drupal8.system-module.1987656-11.patch, failed testing.

mparker17’s picture

Status: Needs work » Needs review
FileSize
3.22 KB

Straight re-roll of the patch; no interdiff.

dawehner’s picture

+++ b/core/modules/system/tests/modules/common_test/lib/Drupal/common_test/Controller/CommonTestController.php
@@ -73,4 +73,16 @@ public function drupalRenderInvalidKeys() {
+  /**
+   * Adds a JavaScript file and a CSS file with a query string appended.
+   */
+  public function jsAndCssQuerystring() {

Can we have just a simple @return statement, please?

mparker17’s picture

OK...

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you very much!!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.