Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Looks like we introduced a small bug in #2050919: Replace local task plugin discovery with YamlDiscovery.
The default weight should be NULL not 0, so that the plugin can determine whether it's set in the definition, or if it needs a default.
The main use case is that that \Drupal\Core\Menu\LocalTaskDefault
sets the weight to -10 for the root tab so it automatically appears on the left.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2087007-4-PASS.patch | 1.44 KB | pwolanin |
#3 | 2087007-3-FAIL.patch | 618 bytes | pwolanin |
#3 | 2087007-3-PASS.patch | 1.44 KB | pwolanin |
#1 | 2087007-1.patch | 857 bytes | pwolanin |
Comments
Comment #1
pwolanin CreditAttribution: pwolanin commentedAlso teaks the a doc line so it's < 80 chars and a little clearer.
Comment #2
dawehnerI guess some test to ensure that would be great.
Comment #3
pwolanin CreditAttribution: pwolanin commentedlooks like a task weight was tweaked at some point to make the tests pass but hid the bug.
The test code in LocalTasksTest itself says:
so clearly it was wrong to set it to 10.
Attached is the test change alone, plus in combination with #1 (modulo a 1 letter doc change).
Comment #4
pwolanin CreditAttribution: pwolanin commentedidk why this is taking hours to run - just re-posting the same patch.
Comment #5
EclipseGc CreditAttribution: EclipseGc commentedOk, seems pretty straight forward to me.
Eclipse
Comment #6
webchickCommitted and pushed to 8.x. Thanks!