Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
In #1986408: Message style update we updated the visual styling of messages to match the #1986434: New visual style for Seven. We decided the leave the icons to a follow up.
Some Libricons are now in core, instructions of how to add and implement them are in #2032773: Use Libricons (icon font) in Seven, consider using it more broadly in core
Comment | File | Size | Author |
---|---|---|---|
#9 | 2075949-add_libricons_to_messages.patch | 6.24 KB | AdamGerthel |
#9 | ios retina.png | 57.99 KB | AdamGerthel |
#9 | svg.png | 15.99 KB | AdamGerthel |
#9 | png.png | 15.88 KB | AdamGerthel |
#6 | 2075949-add_libricons_to_messages.patch | 6.37 KB | AdamGerthel |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedHere you go :)
Comment #2
AdamGerthel CreditAttribution: AdamGerthel commentedCheck, error and warning icons are already included and available in Libricons aren't they?Nevermind, they're not colored there
Comment #3
AdamGerthel CreditAttribution: AdamGerthel commentedHere's a first attempt at adding this. It's my first patch so bare with me.
Comment #4
AdamGerthel CreditAttribution: AdamGerthel commentedHmm, perhaps the old files should be removed as well?
I've searched through core to find any other references to those files and found the following:
message-16-ok.png
- No uses anywhere (after my patch)
message-16-warning.png
- Two uses.
message-16-error.png
- Four uses.
Comment #5
LewisNyman CreditAttribution: LewisNyman commentedLooking good, I think you might want to run the svgs through something like SVGO to remove some of the redundant meta data. Let's remove the icons that are not used and I suppose we'll have to open up a separate issue to replace the icons that are referenced in other files in core.
Comment #6
AdamGerthel CreditAttribution: AdamGerthel commentedHere's a new patch. Metadata removed from the SVG's and deleted message-16-ok.png that isn't used anymore.
Comment #7
AdamGerthel CreditAttribution: AdamGerthel commentedComment #8
Bojhan CreditAttribution: Bojhan commentedThis probably needs some screenshots?
Comment #9
AdamGerthel CreditAttribution: AdamGerthel commentedFixed SVG sizes (I had made them 32x32 by mistake in my last patch). Screenshots attached.
Comment #10
AdamGerthel CreditAttribution: AdamGerthel commentedCreated new issues for the modules using the other files:
#2083945: dblog.module: Update use of icons
#2083947: system.module: Update use of icons to new standards
#2083949: filter.module: Update use of icons to new standards
Comment #11
Bojhan CreditAttribution: Bojhan commentedLooks awesome!
Comment #12
LewisNyman CreditAttribution: LewisNyman commentedCode looks good. RTBC++
Thanks Adam! The icons look so much better.
Committers, please credit Ry5n :)
Comment #13
webchickCommitted and pushed to 8.x. Thanks!
Comment #14
Wim LeersYay :)