ViewsHandlerDiscovery and Core AnnotatedClassDiscovery now no longer need $this->pluginNamespaces inherited from Component AnnotatedClassDiscovery. Instead, plugin lazily are dynamically determined in getPluginNamespaces();
This is since this patch went in:
http://drupalcode.org/project/drupal.git/blobdiff/8b0ea7503d7c61a19acb47...
http://drupalcode.org/project/drupal.git/blobdiff/8b0ea7503d7c61a19acb47...
However, ViewsHandlerDiscovery::__construct() still fills this variable for no reason.
This was introduced before the above mentioned change:
http://drupalcode.org/project/drupal.git/blobdiff/5fc86b002978fc160b98e7...
This should be removed.
Comment | File | Size | Author |
---|---|---|---|
#1 | D8-ViewsHandlerDiscovery-2087551-1.patch | 1.76 KB | donquixote |
Comments
Comment #1
donquixote CreditAttribution: donquixote commentedComment #2
damiankloip CreditAttribution: damiankloip commentedLooks fine to me.
Comment #3
dawehnerTo be honest I would like to understand whether it would be possible to remove the custom discovery mechanism in general.
Comment #4
damiankloip CreditAttribution: damiankloip commentedIt's a good question.
Comment #5
dawehnerWe can remove the custom discovery in a follow up.
Comment #6
donquixote CreditAttribution: donquixote commenteddawehner: thanks!
This patch will remove yet another obstacle for PSR-4,
#2083547: PSR-4: Putting it all together
Comment #7
webchickYay, less code. :)
Committed and pushed to 8.x. Thanks!
Comment #8.0
(not verified) CreditAttribution: commentedgive context to the other commit link.