Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The interface Drupal\Core\Plugin\PluginFormInterface
was added to core since the search plugin patch was first devised. Because that wasn't available during the initial plugin conversion, one-off form methods were added to SearchInterface instead.
Proposed resolution
We should remove the one-off form methods and use this now-standard interface for greater consistency.
Remaining tasks
N/A
User interface changes
N/A
API changes
- Two methods are removed from
Drupal\search\Plugin\SearchInterface
- NodeSearch and SearchExtraTypeSearch methods are changed to conform to PluginFormInterface
- SearchSettingsForm only invokes form methods on plugins that implement PluginFormInterface
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#10 | search-2086201-10.patch | 8.33 KB | pwolanin |
#5 | search-2086201-5.patch | 8.33 KB | tim.plunkett |
#1 | search-2086201-1.patch | 8.32 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThis is what I had in mind.
Comment #2
pwolanin CreditAttribution: pwolanin commentedThe relevant search module tests pass for me locally, and I think this is a good cleanup.
Comment #3
pwolanin CreditAttribution: pwolanin commented#1: search-2086201-1.patch queued for re-testing.
Comment #4
webchickSorry, no longer applies. Seems like a good change though.
Comment #5
tim.plunkettTrivial reroll:
This was moved.
Comment #7
pwolanin CreditAttribution: pwolanin commented#5: search-2086201-5.patch queued for re-testing.
Comment #8
pwolanin CreditAttribution: pwolanin commentedComment #9
alexpottPatch no longer applies.
Comment #10
pwolanin CreditAttribution: pwolanin commentedpatch was able to apply it with fuzz, so just a simple re-roll.
Comment #11
alexpottCommitted 34f0d6d and pushed to 8.x. Thanks!
Comment #12.0
(not verified) CreditAttribution: commentedUpdated issue summary.