Part of #2093143: [meta] Remove calls to @deprecated and "backwards compatibility" procedural functions from core

CommentFileSizeAuthor
#10 remove_deprecate_drupal_strip_dangerous_protocols_2089327-10.patch6.47 KBCyberschorsch
#4 2089327-4.patch6.43 KBthedavidmeister
#1 2089327-1.patch6.43 KBthedavidmeister
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Active » Needs review
FileSize
2089327-1.patch6.43 KB

patch

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix, +Novice

I have done quick search unable to find any more occurrence of drupal_strip_dangerous_protocols so RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Title: Convert all core calls to drupal_strip_dangerous_protocols() to \Drupal\Component\Utility\Url::stripDangerousProtocols() » Convert all core calls to drupal_strip_dangerous_protocols() to \\Drupal\\Component\\Utility\\Url::stripDangerousProtocols()
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs work » Needs review
FileSize
2089327-4.patch6.43 KB

reroll

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

RTBC as per #2

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: -Needs reroll

RTBC +1

thedavidmeister’s picture

thedavidmeister CreditAttribution: thedavidmeister commented
Title: Convert all core calls to drupal_strip_dangerous_protocols() to \\Drupal\\Component\\Utility\\Url::stripDangerousProtocols() » Remove/deprecate calls to drupal_strip_dangerous_protocols() use \\Drupal\\Component\\Utility\\Url::stripDangerousProtocols()
Status: Reviewed & tested by the community » Needs work

Let's actually deprecate drupal_strip_dangerous_protocols()

Cyberschorsch’s picture

Cyberschorsch
Primary language German
CreditAttribution: Cyberschorsch commented
Status: Needs work » Reviewed & tested by the community

I don't seem to find anymore occurrence of drupal_strip_dangerous_protocols() so this should be fixed?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

Sorry, doesn't seem to apply. :(

Cyberschorsch’s picture

Cyberschorsch
Primary language German
CreditAttribution: Cyberschorsch commented
Status: Needs work » Needs review
FileSize
remove_deprecate_drupal_strip_dangerous_protocols_2089327-10.patch6.47 KB

I rerolled the patch.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Title: Remove/deprecate calls to drupal_strip_dangerous_protocols() use \\Drupal\\Component\\Utility\\Url::stripDangerousProtocols() » Remove / deprecate calls to drupal_strip_dangerous_protocols() use \Drupal\Component\Utility\Url::stripDangerousProtocols()
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.

TR’s picture

TR CreditAttribution: TR commented
Issue summary: View changes
Issue tags: +Needs change record

This needs to be mentioned somewhere in a change record.