Feeds FileMaker imports data from FileMaker into Drupal. The module connects to the FileMaker PHP API to retrieve a set of records. The records can be filtered by multiple criteria (e.g. surname = Smith, city = Dundee).
The module consists of 2 feeds plugins - FileMaker Fetcher and FileMaker Parser. It is intended to be used with the Node Processor in order to pull FileMaker data into Drupal nodes.
As far as I can tell there are no other modules that implement this functionality. There is the FileMaker module, however it goes in the opposite direction - from Drupal to FileMaker.
Project page: https://drupal.org/sandbox/littledynamo/2083771
Git repository: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/littledynamo/2083771.git feeds_filemaker
Reviews of Other Projects
https://drupal.org/node/2084467#comment-7842627
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxlittledynamo2083771git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
littledynamo CreditAttribution: littledynamo commentedFixed up issues from pareview.sh
Comment #2.0
littledynamo CreditAttribution: littledynamo commentedMissed a word
Comment #3
AjitSReview:
This is my first review. So, please correct if I make any mistake. Just some things I've noticed:
git clone http://git.drupal.org/sandbox/littledynamo/2083771.git feeds_filemaker
One more thing, on line 10 of feeds_filemaker.install I see a call to
ctools_get_plugins_reset()
. Doesn't this mean that the module should be dependent on CTools?Comment #3.0
AjitSAdded reviews of other projects section
Comment #4
littledynamo CreditAttribution: littledynamo commentedHi AJit,
Thanks for reviewing my module:
- Git clone link fixed
- Fixed up the README.txt file issues form pareview.sh
- Deleted master branch
The module is dependent on Feeds, which is dependent on CTools, so I don't need to directly add the CTools dependency.
Comment #5
bluesomewhere CreditAttribution: bluesomewhere commentedHi littledynamo,
Like Ajits, this is my first review, and unfortunately I do not have a FileMaker server with which to thoroughly test this, so someone may need to come along to do just that.
I did not find any issues in documentation or code syntax and style. This also appears conceptually solid based on my understanding gleaned from recent work with Feeds XPath Parser. I only see one thing that ought to be fixed (and it's not in the module), and have one suggestion that perhaps more style than anything else:
Hopefully someone can come and test this code soon! Mundane details aside, it seems ready to rock and I know folks who would have loved to have this yesterday :) Thanks for your efforts.
Comment #5.0
bluesomewhere CreditAttribution: bluesomewhere commentedFixed git clone command
Comment #6
littledynamo CreditAttribution: littledynamo commentedHi bluesomewhere,
Thanks for the review!
I've updated the git clone link, thanks for pointing that out. The naming convention for Feeds plugins had not registered with me, but I think it looks better so I've updated that too.
It's nice to hear that this module seems useful, I was actually quite surprised that there wasn't already a Drupal module for pulling data from FileMaker.
I'll see if a colleague can vouch for the functionality, so that we can get this RTBC.
Comment #7
littledynamo CreditAttribution: littledynamo commentedComment #8
littledynamo CreditAttribution: littledynamo commentedComment #9
softescu CreditAttribution: softescu commentedAutomated code checks return clean.
Manual review (unable to test with FileMaker):
- README.txt:3 first letter typo
- Description "Fetch and parse data from Filemaker it's PHP API" seems incorrect gramatically
Please fix these two small issues, module code and usability seems to be clean and ready for promotion.
Comment #10
klausiTwo minor spelling errors are surely not application blockers, any other major flaws you found?
Comment #11
softescu CreditAttribution: softescu commentedComment #11.0
softescu CreditAttribution: softescu commentedEdited git clone url
Comment #12
klausiSorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.
manual review:
But that are not blockers, so ...
Thanks for your contribution, littledynamo!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #13
littledynamo CreditAttribution: littledynamo commentedAwesome! I'll look into getting the non-blocking issues fixed.
Thanks so much.