Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Issue summary updated: #42
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Beta phase evaluation
Issue category | Task because it's updating code to the new API/code style |
---|---|
Issue priority | Major because it's a refactoring task |
Unfrozen changes | Unfrozen because it is a change in automated tests |
Prioritized changes | The main goal of this issue is removing deprecated code style. |
Disruption | The change is not disruptive |
Comment | File | Size | Author |
---|---|---|---|
#34 | drupal8.test_page.1987868-34.patch | 12.18 KB | disasm |
#32 | drupal8.test_page.1987868-32.patch | 120.47 KB | disasm |
#32 | interdiff.txt | 564 bytes | disasm |
#28 | drupal8.test_page.1987868-28.patch | 12.13 KB | disasm |
#28 | interdiff.txt | 1.76 KB | disasm |
Comments
Comment #1
tim.plunkettBlocks #1908756: Separate Action Links (MENU_LOCAL_ACTION) from hook_menu()
Comment #2
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #3
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #4
disasm CreditAttribution: disasm commentedconverting test_page_test_page to a new controller and updating all the menu hooks that call it.
Comment #5
disasm CreditAttribution: disasm commentedforgot to rebase before creating the diff.
Comment #7
disasm CreditAttribution: disasm commentedTry again with the correct namespace.
Comment #9
disasm CreditAttribution: disasm commentedwrong key on hook_menu entries (route name -> route_name).
Comment #10
disasm CreditAttribution: disasm commentedforgot to rebase
Comment #12
disasm CreditAttribution: disasm commentedMoving testPage method to Test Controller added by #2032535: Resolve 'title' using the route and render array.
Comment #14
disasm CreditAttribution: disasm commentedattached is a patch that converts drupal_add_js and drupal_set_title to render array.
Comment #16
disasm CreditAttribution: disasm commentedI really need to run phpcs on patches when I work on them after midnight ;-) Fixing two syntax errors.
Comment #18
jibranWhy we have a comment out code in the patch?
Comment #19
disasm CreditAttribution: disasm commentedI really messed up that branch last night. This interdiff goes back to #12.
Comment #21
disasm CreditAttribution: disasm commentedAdding hook_menu back in. Some reason when the entry doesn't exist, no menus show up at all. This is a temporary fix until we figure out what the reason for it is.
Comment #23
disasm CreditAttribution: disasm commentedfixing more tests. If this is green, will open up another issue to resolve the menu issue when no hook_menu exists.
Comment #25
disasm CreditAttribution: disasm commentedSome more test fixes.
Comment #26
xjmThanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.
Comment #27
dawehnerMissing title on all of them.
Missing @return.
This menu callback can be removed entirely. ... also missing title on the routing yml
Comment #28
disasm CreditAttribution: disasm commentedremoving hook_menu. Adding @return, adding title.
Comment #30
disasm CreditAttribution: disasm commented#28: drupal8.test_page.1987868-28.patch queued for re-testing.
Comment #32
disasm CreditAttribution: disasm commentedadding hook_menu back in.
Comment #34
disasm CreditAttribution: disasm commentedreroll!
Comment #36
disasm CreditAttribution: disasm commented#34: drupal8.test_page.1987868-34.patch queued for re-testing.
Comment #37
dawehnerWe could just remove that.
Comment #38
disasm CreditAttribution: disasm commentedsadly, that can't be removed without altering tests: Path from menu_get_item('test-page') is equal to 'test-page'. If you remove it, menu_get_item doesn't know
about test-page.
Comment #39
xjm34: drupal8.test_page.1987868-34.patch queued for re-testing.
Comment #41
xjmComment #42
valthebaldAdded beta stage evaluation
Comment #43
valthebaldWorking on it as part of #SprintWeekend2015
Comment #44
valthebaldThis issue is already solved by [#2301137]
Comment #45
David Hernández CreditAttribution: David Hernández commentedHello!
Thank you for working on this issue!
We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.
Comment #46
penyaskito@valthebald Wrong issue link?
Comment #47
DamienMcKennaRemoved the "Needs reroll" seeing as the issue was closed.