Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/hal/lib/Drupal/hal/Normalizer/EntityNormalizer.php

Line 93: Unused local variable $links

CommentFileSizeAuthor
#1 drupal-core-remove-unused-local-variable-2081197-1.patch661 bytessmira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smira’s picture

smira CreditAttribution: smira commented
Status: Active » Needs review
FileSize
drupal-core-remove-unused-local-variable-2081197-1.patch661 bytes

my take on the matter though i would probably opt to mark as "wont fix" instead just to be safe...

lorique’s picture

lorique CreditAttribution: lorique commented
Status: Needs review » Reviewed & tested by the community

The variable is gone from EntityNormalizer->denormalize() method, and is used nowhere in the method. thus it can and has been safely removed.

Changing status. Thank you for your patch @smiro.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.