Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.#1778122-95: Enable modules to inject attributes into field formatters, so that RDF attributes get output showed that the test upgrade ends up creating an EntityDisplay object that contains data for test_deleted_field
We should make sure entity displays do not get populated with fiedls that are deleted at the time the upgrade runs.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | entity_display_update-2089273-3-test-only.patch | 1.35 KB | yched |
| #3 | entity_display_update-2089273-3.patch | 4.71 KB | yched |
| #3 | interdiff.txt | 497 bytes | yched |
| #1 | entity_display_update-2089273-1-test-only.patch | 1.36 KB | yched |
| #1 | entity_display_update-2089273-1.patch | 4.72 KB | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedShould fix it - diff is big, but this just wraps code in an
if (instance is not deleted) {Comment #3
yched CreditAttribution: yched commentedSilly.
Comment #4
swentel CreditAttribution: swentel commentedNote, related, #2078505: Don't migrate deleted fields in the upgrade path
Looks good otherwise.
Comment #5
webchickJust a question, does the d7-filled-db or whatever it is actually have deleted fields in it? In other words, are those added tests actually testing anything?
Comment #6
yched CreditAttribution: yched commentedYes it does - or the test-only patch would't fail :-)
Comment #7
webchickDuh. :P Right. :P
Committed and pushed to 8.x. Thanks! Yay better upgrade path! :)
Comment #8.0
(not verified) CreditAttribution: commentedmore specific