Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/node/lib/Drupal/node/Tests/Views/FilterUidRevisionTest.php

Line 54: Unused local variable $node

CommentFileSizeAuthor
#5 drupal_core-unused_local_variable-2080065-5.patch731 bytesPete B
#3 drupal_core-unused_local_variable-2080065-3.patch1.4 KBPete B
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

littledynamo’s picture

littledynamo CreditAttribution: littledynamo commented
Assigned: Unassigned » littledynamo
littledynamo’s picture

littledynamo CreditAttribution: littledynamo commented
Pete B’s picture

Pete B CreditAttribution: Pete B commented
Status: Active » Needs review
FileSize
drupal_core-unused_local_variable-2080065-3.patch1.4 KB

None of the $node variables were being used.

Status: Needs review » Needs work

The last submitted patch, drupal_core-unused_local_variable-2080065-3.patch, failed testing.

Pete B’s picture

Pete B CreditAttribution: Pete B commented
Status: Needs work » Needs review
FileSize
drupal_core-unused_local_variable-2080065-5.patch731 bytes

Ok, so maybe they were used once or twice...

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented

Thanks @Pete B for patch.

I have review and tested the patch its working fine for me.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed cddf217 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.