Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up from #1840980: [meta] Bootstrap 3.0.
Comment | File | Size | Author |
---|---|---|---|
#8 | Screenshot from 2013-09-20 23:45:12.png | 22.23 KB | kslonka |
#7 | bootstrap-update-and-recompile-2084331-7.patch | 12.91 KB | markhalliwell |
#7 | interdiff.txt | 11.39 KB | markhalliwell |
#2 | recompile_overrides_2084331_3.patch | 1.76 KB | Denes.Szabo |
Comments
Comment #1
heylookalive CreditAttribution: heylookalive commentedCan someone explain the overrides that are currently in place? I've found a few bits which are off but I don't want to wade in and disrupt legacy things without knowing why they're there first. Also where's the less file?
.help-block, .control-group .help-inline
isn't neededCould also improve the autocomplete drop down to look a bit nicer too.
Comment #2
Denes.Szabo CreditAttribution: Denes.Szabo commentedI just attached my version. I started to work on the bootstrap3 subtheme, my lessc just found a few missing variables. I replaced them according to the variables.less. Maybe, I did not clearly understand the bootstrap theme (naming conventions, etc), but I hope, my little work helps.
Comment #3
markhalliwell@Denes.Szabo thanks for the patch! This certainly helps get us on the right path, but still a lot of work to do on this issue :)
Comment #4
Denes.Szabo CreditAttribution: Denes.Szabo commentedYeah, I agree…
Have you any vision/plan, what, how? I have a little time now, so I can work on it.
Comment #5
markhalliwellIn reality, this issue should be the last one to patch (IMHO). We won't necessarily know what other issues could affect this one, until we're close to an RC.
Comment #6
markhalliwellMarked #2093937: Missing variable declarations in bootstrap_subtheme as a dup of this issue.
Comment #7
markhalliwellHere is the rest of what I can tell needs to be updated (so far). Also compiled it.
Comment #8
kslonka CreditAttribution: kslonka commentedheight: auto; causes firefox to render this incorrectly. Do we really need that?
Comment #9
markhalliwellProbably not, no. They've changed their styling, obviously, so I'll remove it. We can always put it back in/modify it if needed. I'll add this fix after patching.
Comment #10
markhalliwellCommitted #7:7660918 to 7.x-3.x.
Committed #8:f5b7f0f to 7.x-3.x.
Comment #11
markhalliwellComment #12
kslonka CreditAttribution: kslonka commentedWe should remove @media @normal, @wide from body styling because we use navbar that is fixed on top as default. (it should always have padding-top)
Comment #13
markhalliwell@kslonka, open new issues please.