Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Core still has a couple surprising references to field_sql_storage:
- Some tests try to enable it - you'd expect this would break, but it seems to pass
- DatabaseSotrageController::onBundleRename() checks $field['storage']['type'], which doesn't exist anymore. Shows we lack some tests here.
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff.txt | 1.25 KB | Hydra |
#11 | field_sql_storage-2086095-11.patch | 12.99 KB | Hydra |
#10 | field_sql_storage-2086095-10.patch | 14.36 KB | swentel |
#8 | field_sql_storage-2086095-8.patch | 14.29 KB | yched |
#2 | field_sql_storage-2086095-2.patch | 14.33 KB | yched |
Comments
Comment #1
yched CreditAttribution: yched commentedPatch.
- There was another problem in DatabaseStorageController::onBundleRename() - the method now runs before instances are updated, so we need to get instances associated to the old bundle name.
- The test needed to fix inconsistencies in entity_test_[create|rename|delete]_bundle() as compared to entity_test_entity_bundle_info(). Hope this won't break other things :-/
Comment #2
yched CreditAttribution: yched commented#1 had some tests commented out...
Comment #4
yched CreditAttribution: yched commented#2: field_sql_storage-2086095-2.patch queued for re-testing.
Comment #5
jibranTagging.
Comment #6
BerdirAwesome, @yched++!
Nice, that's why the call below doesn't fail ;)
No test-only patch, but I manually confirmed that the added tests fail without the fix. Changes look great, so I think this is ready to go.
Comment #7
webchickPatch no longer applies.
Comment #8
yched CreditAttribution: yched commentedReroll
Comment #9
alexpottPatch no longer applies.
Comment #10
swentel CreditAttribution: swentel commentedComment #11
Hydra CreditAttribution: Hydra commentedThe module list in EditorFileUsage test has been shortened in #1605290: Enable entity render caching with cache tag support, so I removed this one from the patch.
Same here
Rerolled the patch with the changes, so basically nothing changed and still RTBC.
Comment #13
swentel CreditAttribution: swentel commented#11: field_sql_storage-2086095-11.patch queued for re-testing.
Comment #14
swentel CreditAttribution: swentel commentedShould be bot fluke
Comment #15
alexpottCommitted e40eb19 and pushed to 8.x. Thanks!