Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
ConfigEntityInterface::setOriginalID() should return $this, just like any other setter.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff.txt | 1.15 KB | Xano |
#8 | drupal_2088241_8.patch | 7.68 KB | Xano |
#7 | drupal_2088241_6.patch | 7.71 KB | Xano |
#7 | interdiff.txt | 729 bytes | Xano |
#3 | drupal_2088241_3.patch | 6.81 KB | Xano |
Comments
Comment #1
XanoAlso, should the method name not be setOriginalId()?
Comment #2
dawehnerI also agree that it should be name setOriginalId
Comment #3
XanoComment #4
Xano.
Comment #6
dawehnerWe are using '@return self' in quite some places which gives even more information.
We could even check that it is the same object using spl_object_hash
Comment #7
XanoComment #8
XanoComment #9
dawehnerThank you!
Comment #10
xjmComment #11
webchickCommitted and pushed to 8.x. Thanks!
Will need a change notice.
Comment #12
XanoChange notice is at https://drupal.org/node/2107951.
Comment #13
XanoFor some reason the capitalization issue was never fixed or rolled back. See #2113319: Rename getOriginalID() to getOriginalId() and setOriginalID() to setOriginalId().